This is a public, read-only report. Striff reads this repository's docs, turns each sentence that makes a claim about the code into a rule, and checks the rule against the code on the default branch. How this works
State today _watermarkMs long, Action needed when fixed-MV lands Make optional populated only for TIME
MaterializedViewRuntimeMetadata has _watermarkMs
Holds
Interface MaterializedViewRuntimeMetadata, State today _partitions Map<Long, PartitionInfo>, Action needed when fixed-MV lands Generalize to Map<PartitionKey, PartitionInfo> (or Map<String, …> with a separate PartitionKind )
MaterializedViewDefinitionMetadata has rewriteEnabled
Holds
MaterializedViewDefinitionMetadata has stalenessThresholdMs
Holds
watermarkMs plus a Map<Long, PartitionInfo> keyed by bucketStartMs.
MaterializedViewRuntimeMetadata has watermarkMs
Holds
The public entry point onBaseTableFullInvalidation(rawTableName) exists today (PR 1 shipped it for the time-MV "unknown range" case);
MaterializedViewConsistencyManager has an onBaseTableFullInvalidation method
Holds
Interface MaterializedViewAnalyzer.validateSourceTable, State today Time-MV only, Action needed when fixed-MV lands Sibling validator for CATEGORICAL require partition column existence and (optional) frozen key list
MaterializedViewAnalyzer has validateSourceTable
Holds
Interface MaterializedViewAnalyzer.validateTaskConfigs, State today Hard-requires bucketTimePeriod, Action needed when fixed-MV lands Make required-on- TIME optional / absent on CATEGORICAL
MaterializedViewAnalyzer has validateTaskConfigs
Holds
Interface MaterializedViewTaskScheduler.generateTasks, State today Watermark + APPEND, Action needed when fixed-MV lands Branch on partitionKind CATEGORICAL goes through FIFO-STALE + refresh-interval logic
MaterializedViewTaskScheduler has generateTasks
Holds
Interface MaterializedViewTaskExecutor.executeTask, State today Window-based, Action needed when fixed-MV lands Branch on task-config partitionKey shape segment building is unchanged
MaterializedViewTaskExecutor has executeTask
Holds
JSONMessageDecoder — a StreamMessageDecoder for real-time (streaming) ingestion.
JSONRecordReader — a RecordReader for batch ingestion of newline-delimited JSON files.
JSONRecordReader implements RecordReader
Holds
JSONRecordExtractor — the shared extractor that turns a parsed JSON object into a Pinot GenericRow.
JSONRecordExtractor depends on GenericRow
Holds
DdlCompiler.compile(String sql) — single static entry point, returns a CompiledDdl discriminated by DdlOperation.
DdlCompiler has a compile method
Holds
The IR is what populates the Schema (via toFieldSpec) and the TableConfig (via PropertyMapping.apply).
PropertyMapping has apply
Holds
DataTypeMapper.resolve(String) is case-insensitive (Locale.ROOT) and accepts both ANSI-SQL and Pinot-native names:
DataTypeMapper has a resolve method
Holds
The compiler runs dataType.convert(literalString) and surfaces a DdlCompilationException mapped to HTTP 400 if it fails.
DataType has a convert method
Holds
validateTableConfig is then called against the stored schema (when one exists), not the compiled schema, so upsert/dedup PK validation sees the canonical PK list rather than the synthesized empty list from the DDL column-list-only projection.
TableConfigValidationUtils has validateTableConfig
Holds
TableConfigTunerUtils.applyTunerConfigs runs before validation, mirroring POST /tables.
TableConfigTunerUtils has applyTunerConfigs
Holds
CanonicalDdlEmitter.emit(schema, tableConfig, databaseName?) produces a deterministic DDL string.
CanonicalDdlEmitter has an emit method
Holds
PropertyExtractor calls PropertyMapping.isReservedRoundTripKey(lowerKey) on every custom-config entry it encounters.
PropertyMapping has an isReservedRoundTripKey method
Holds
The SPI invariant TableConfigUtils.validateMaterializedViewInvariants keeps the flag and the task.MaterializedViewTask.definedSQL body consistent, so the dispatch never has to inspect the task block to decide identity.
TableConfigUtils has validateMaterializedViewInvariants
Holds
MaterializedViewPropertyRouter.periodToCron rewrites every accepted REFRESH EVERY '<N><unit>' value into a Quartz cron expression that the scheduler ingests.
MaterializedViewPropertyRouter has periodToCron
Holds
The reverse direction (cronToPeriod) must be the exact inverse:
MaterializedViewPropertyRouter has cronToPeriod
Holds
Adding a knob to MaterializedViewPropertyRouter.TASK_CONFIG_KEYS (the forward-router map; the reverse extractor consults it via canonicalKnobName(...)) is the only edit needed to promote a future knob to bare-DDL form.
MaterializedViewPropertyRouter has TASK_CONFIG_KEYS
Holds
The compiler stores the user's definedSQL as the verbatim substring of the original DDL covered by the AS <query> parser node (see DdlCompiler.extractDefinedSql).
DdlCompiler has extractDefinedSql
Holds
The check lives in the controller (PinotDdlRestletResource.executeShowCreate / executeShowCreateMaterializedView) and delegates to the canonical TableConfig#isMaterializedView flag — the same predicate the emitter dispatches on — so a config that the emitter would have routed through the MV branch is caught before any rendering happens.
2 rules from this sentence
PinotDdlRestletResource has executeShowCreate
Holds
PinotDdlRestletResource has executeShowCreateMaterializedView
Holds
Compile.DdlCompiler.compile(sql) → CompiledDdl.
DdlCompiler depends on CompiledDdl
Holds
MV-specific compile route.DdlCompiler.compileCreateMaterializedView routes REFRESH EVERY '<period>', AS <query>, and MV-specific knobs through MaterializedViewPropertyRouter before invoking the shared validateTableConfig (see §4 / §5.2).
2 rules from this sentence
DdlCompiler depends on MaterializedViewPropertyRouter
Holds
DdlCompiler has compileCreateMaterializedView
Holds
Both §6.4 and §6.7 share the same canonical TableConfig#isMaterializedView flag the emitter dispatches on, so the controller never asks the emitter to render a form that disagrees with the underlying TableConfig shape.
TableConfig has isMaterializedView
Holds
Cleanup is delegated entirely to PinotHelixResourceManager#deleteTable for the same reason PR4's SHOW CREATE was deliberately small: that path is already the single source of truth for "drop a Pinot table, including any MV metadata it carries" — adding a parallel cleanup in the controller would risk drift between the two doors.
PinotHelixResourceManager has deleteTable
Holds
No ZK schema change.DdlCompiler returns a stock (Schema, TableConfig) pair and persists them through the existing PinotHelixResourceManager paths.
2 rules from this sentence
DdlCompiler depends on Schema
Holds
DdlCompiler depends on TableConfig
Holds
ZK writes (addSchema, addTable, deleteTable) go through the existing PinotHelixResourceManager paths — no new ZK write surface introduced.